[VOTE] Ratis Thirdparty 0.2.0 rc0

Discussion:

Josh Elser

2018-12-03 20:48:05 UTC

IPMC,

Please find the following PPMC VOTE information which just passed.

Note that the delta over the 0.1.0 is extremely small, should be a
super-trivial vote.

VOTE (original text below the fold):
https://lists.apache.org/thread.html/209baab5d7f3410b9837076d9935bb81305df91edb69a52ffbae7f4f@%3Cdev.ratis.apache.org%3E

RESULT:
https://lists.apache.org/thread.html/4e80dd12f15076edc786f082f882c82300557fd4f533dec535364d61@%3Cdev.ratis.apache.org%3E

This will be open for (at least) the customary 72hours -- 2018/12/06
2100 GMT.

Please note the two IPMC binding votes already from myself and Jitendra.

- Josh

-------- Forwarded Message --------
Subject: [VOTE] Ratis Thirdparty 0.2.0 rc0
Date: Fri, 30 Nov 2018 15:33:19 -0500
From: Josh Elser <***@apache.org>
To: ***@ratis.incubator.apache.org

Hi,

Please on the following as Ratis Thirdparty 0.2.0:

The release artifact (in source form only) is found at:

https://dist.apache.org/repos/dist/dev/incubator/ratis/thirdparty/0.2.0-rc0/ratis-thirdparty-0.2.0-incubating-src.tar.gz

SHA512 checksum is:

D9D87B40 170A3DF6 07538DC5 E6BDF6D3 D93CE7EA DDCC9C7F A077EB99 664C704D
412E54DC 6C402A3A 67C9B5EF 959272FE 953D8189 68613802 BABF3C6A 621887CA

The signature (and all files) can be found here:
https://dist.apache.org/repos/dist/dev/incubator/ratis/thirdparty/0.2.0-rc0/

The SHA1 for the corresponding commit in Git is:
754f0c730eda3dc5f1b90bed0669ca86d5262747

There is only one change in 0.2.0 (over 0.1.0) is including the Netty
native libraries. Thus, there is no other functional change over the
0.1.0 release.

For testing with downstream components, you may use the Maven staging
repository:
https://repository.apache.org/content/repositories/orgapacheratis-1009/

Here's my +1 (binding)

This will be open for at least 72 hours (2018/12/03 2000 GMT).

- Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Mohammad Asif Siddiqui

2018-12-04 05:13:40 UTC

Permalink

+1 (non-binding)

Checks Done:
- incubating in name
- hashes and signatures are good
- DISCLAIMER/NOTICE/LICENSE exists
- ran RAT tool
- checked for archive matching git tag

Suggestions :
- It's better to give a link for the git tag from which the release is made for easy verification by IPMC members.
- In my opinion it's good to maintain the Release Notes for a even a small change for each Release.

Regards
Asif

Post by Josh Elser
IPMC,
Please find the following PPMC VOTE information which just passed.
Note that the delta over the 0.1.0 is extremely small, should be a
super-trivial vote.
This will be open for (at least) the customary 72hours -- 2018/12/06
2100 GMT.
Please note the two IPMC binding votes already from myself and Jitendra.
- Josh
-------- Forwarded Message --------
Subject: [VOTE] Ratis Thirdparty 0.2.0 rc0
Date: Fri, 30 Nov 2018 15:33:19 -0500
Hi,
https://dist.apache.org/repos/dist/dev/incubator/ratis/thirdparty/0.2.0-rc0/ratis-thirdparty-0.2.0-incubating-src.tar.gz
D9D87B40 170A3DF6 07538DC5 E6BDF6D3 D93CE7EA DDCC9C7F A077EB99 664C704D
412E54DC 6C402A3A 67C9B5EF 959272FE 953D8189 68613802 BABF3C6A 621887CA
https://dist.apache.org/repos/dist/dev/incubator/ratis/thirdparty/0.2.0-rc0/
754f0c730eda3dc5f1b90bed0669ca86d5262747
There is only one change in 0.2.0 (over 0.1.0) is including the Netty
native libraries. Thus, there is no other functional change over the
0.1.0 release.
For testing with downstream components, you may use the Maven staging
https://repository.apache.org/content/repositories/orgapacheratis-1009/
Here's my +1 (binding)
This will be open for at least 72 hours (2018/12/03 2000 GMT).
- Josh
---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Justin Mclean

2018-12-04 07:14:47 UTC

Permalink

Hi,

+1 binding but there probably an issue you’ll need to look into before ether net release.

I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE correct
- All ASF files have ASF header
- No binary files
- Can compile from source

The LICENSE and NOTICE additions in ratis-thirdparty-0.2.0-incubating/misc/src/main/appended-resources/META-INF/ do not look correct to me, as it seem it would be missing LICENSE information (i.e. the software mentioned in NOTICE) and you have items in NOTICE that are not correct, in general it’s only the copyright lines from other included ALv2 software NOTICE files or relocated copyright files that go in NOTICE.

You may want to remove the .mds file [1]

Thanks,
Justin

1.https://www.apache.org/dev/release-distribution#sigs-and-sums
---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Josh Elser

2018-12-04 16:29:53 UTC

Permalink

Thanks for the quick vote, Justin!

Post by Justin Mclean
Hi,
+1 binding but there probably an issue you’ll need to look into before ether net release.
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE correct
- All ASF files have ASF header
- No binary files
- Can compile from source
The LICENSE and NOTICE additions in ratis-thirdparty-0.2.0-incubating/misc/src/main/appended-resources/META-INF/ do not look correct to me, as it seem it would be missing LICENSE information (i.e. the software mentioned in NOTICE) and you have items in NOTICE that are not correct, in general it’s only the copyright lines from other included ALv2 software NOTICE files or relocated copyright files that go in NOTICE.

Are we looking at different things, Justin? The NOTICE file in the
directory you mention only has copyright information for bundled
software (and text to help us know to what product that copyright
statement applies). Are you expecting a more verbatim inclusion of the
full NOTICE content and not the relevant "spirit"?

For LICENSE, gRPC is ALv2 (no mention required), protobuf-java is
3-clause BSD (which is included), netty is ALv2 (no mention required),
and gson is also ALv2. What do you see that's missing?

Post by Justin Mclean
You may want to remove the .mds file [1]

What's your read on this? Remove them because of little/no value over
sha xsum files (which are required by ASF policy)?

I fixed the sha xsum naming over the previous release, but didn't take
the time to remove the .mds since it wasn't _against_ policy to remove it.

Post by Justin Mclean
Thanks,
Justin
1.https://www.apache.org/dev/release-distribution#sigs-and-sums
---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Justin Mclean

2018-12-04 20:48:52 UTC

Permalink

Hi,

That is not the purpose of NOTICE.

Are you expecting a more verbatim inclusion of the full NOTICE content and not the relevant "spirit”?

See [1]

For LICENSE, gRPC is ALv2 (no mention required), protobuf-java is 3-clause BSD (which is included), netty is ALv2 (no mention required), and gson is also ALv2. What do you see that's missing?

It’s not required but recommend that all licenses be listed in LICENSE. [2]

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#mod-notice
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Josh Elser

2018-12-07 00:14:52 UTC

Permalink

I guess I just need to accept that I'll never have a firm grasp on L&N
construction. I'm still a bit befuddled. Thanks for taking the time to
explain, Justin.

I would have confidently thought that bundled software's copyright
statements always had a place in NOTICE. Also, a surprise to me that we
want all licenses in LICENSE. Will try to pick these up for the next
release.

Post by Justin Mclean
Hi,

That is not the purpose of NOTICE.

Are you expecting a more verbatim inclusion of the full NOTICE content and not the relevant "spirit”?

See [1]

For LICENSE, gRPC is ALv2 (no mention required), protobuf-java is 3-clause BSD (which is included), netty is ALv2 (no mention required), and gson is also ALv2. What do you see that's missing?

---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Justin Mclean

2018-12-07 02:52:47 UTC

Permalink

Hi,

I would have confidently thought that bundled software's copyright statements always had a place in NOTICE. Also, a surprise to me that we want all licenses in LICENSE. Will try to pick these up for the next release.

I take a look at it when done of you want, just ping me.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Justin Mclean

2018-12-09 01:42:27 UTC

Permalink

Hi,

Also this may help [1] along with the other link I’ve sent.

Thanks,
Justin

1. https://wiki.apache.org/incubator/IncubatorReleaseChecklist
---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org

Josh Elser

2018-12-07 00:11:24 UTC

Permalink

This vote passes with 3 binding +1's and 1 non-binding +1.

Thanks all.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-***@incubator.apache.org
For additional commands, e-mail: general-***@incubator.apache.org